[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: How to enable more than 256 pty's?



* Ed Schouten <ed_(_at_)_fxq_(_dot_)_nl> wrote:
> * Vlad GALU <dudu_(_at_)_dudu_(_dot_)_ro> wrote:
> > On 10/2/07, Dag-Erling Smørgrav <des_(_at_)_des_(_dot_)_no> wrote:
> > > "Vlad GALU" <dudu_(_at_)_dudu_(_dot_)_ro> writes:
> > > > The symptoms were exhibited even with rev. 1.16. I've CC'ed him so
> > > > he can catch up with the thread.
> > >
> > > Which symptoms?  I can no longer reproduce the hang-on-close bug.
> > 
> >    Strangely enough, me neither. In his case, allocated pts' wouldn't
> > get deallocated once the sessions ended.
> 
> This is a known issue IIRC. See line 245 of tty_pts.c 1.16. Can be
> easily reproduced by killing the sshd while apps are still running in
> the shell.
> 
> I thought we weren't able to destroy the device there, because you can't
> destroy a TTY when it is used by an application (i.e. when it's the
> controlling terminal).

Thought about this 2 seconds after I sent my message: this is also
responsible for the `zombie jails': tty's are made with make_dev_cred,
which causes ucred's to be leaked, which eventually causes prisons to be
leaked.

-- 
 Ed Schouten <ed_(_at_)_fxq_(_dot_)_nl>
 WWW: http://g-rave.nl/

Attachment: pgpF8z3dV3YbL.pgp
Description: PGP signature


Visit your host, monkey.org