On Thu, 01 Dec 2005 15:20:26 +0100 Alexander Leidinger <Alexander_(_at_)_Leidinger_(_dot_)_net> wrote: > Jean-Yves Lefort <jylefort_(_at_)_FreeBSD_(_dot_)_org> wrote: > > [moving to emulation_(_at_)_] > > I have a backlog of cvs-all mails... I'm slowly catching up and noticed this > one without further looking if someone wrote some comments (but I looked at > rev 1.2 of the file). > > > jylefort 2005-11-26 19:18:51 UTC > > > > FreeBSD ports repository > > > > Added files: > > audio/linux-openal bsd.linux.mk > > Log: > > Add my RPM support infrastructure. > ^^ > Isn't this a little bit selfish? ;-) > > Ok, more serious comments (*constructive* critic): > - that's the wrong name for this file, bsd.rpm.mk or > bsd.linuxrpm.mk would be better, since it does not contain > all linux related mk-fu Agreed. > - install-time generated plists are evil (as per discussion on > ports@ a while ago (and as of very recent experience with the > linux ports), so the pre-install target should be removed and > a real plist should be generated), have a look at the linux-gtk > Makefile for a target which generates an initial plist (needs > to be modified a little bit afterwards) So we still don't agree on this. I guess we never will. :( > - it should be installed into PORTSDIR/Mk, so that other port can > use it I agree, but I don't think that I have the right to (nor that it is good to) add files to Mk/ without portmgr reviewal. I had planned to contact emulation@ and discuss the steps needed to move the file to Mk/ and have it pulled in from bsd.port.mk (via a USE_LINUX_RPM knob, or something). Glad to see that you read cvs-ports. :) > - does the ppc have a linuxolator? I'm not sure (I guess not). I'll remove the powerpc stuff if someone confirms that there's no linux emulation on powerpc. > - why do you use different ways of specifying the paths in DESCR > and MD5_FILE? > - why do you specify DESCR at all? The idea is to use the FreeBSD native port's pkg-descr. > - INSTALLS_LINUX_SHLIB should be removed, fix the FreeBSD one > instead to not do anything in the USE_LINUX case and reuse the > name of the FreeBSD one (-> more consistent and easy > description on the porters handbook) Agreed. > In general it's nice to see someone working on this. And I like the idea to > use rpm2cpio instead of rpm. We could get rid of the rpm-db in the linux > base ports this way (this removes some of those annoying warnings on > pkg_deinstall). And it allows to modify the contents before installing, which is not possible when installing with rpm. I don't know what to do next. I can file a PR for inclusion in Mk/, but it'd feature my own plist generator. Directions are welcome. -- Jean-Yves Lefort jylefort_(_at_)_FreeBSD_(_dot_)_org http://lefort.be.eu.org/
Attachment:
pgp64N8ciPeZo.pgp
Description: PGP signature