[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: acpi_ibm(4): new radio kill switch (readonly) sysctl



On 4/18/07, Nate Lawson <nate_(_at_)_root_(_dot_)_org> wrote:
Rong-en Fan wrote:
> As pointed out by Henrik Brix Andersen, I adds a sysctl entry
> that shows the status of radio kill switch found on some ThinkPad:
>
> http://people.freebsd.org/~rafan/acpi_ibm_killswitch.diff
>
> dev.acpi_ibm.0.killswitch = 0 means the switch is off. It seems that
> no acpi event will be generated when the value changes (actually,
> my x60 does not generate any events when I presses FN+something).
> Otherwise, we can hook it in devd.conf and remove wireless driver when
> kill switch is on...
>
> Any comments?

Seems fine to me.  But as to the name of the sysctl -- it should be more
logical.  How about renaming it to dev.acpi_ibm.0.radio_enable and when
1, the radio is enabled?  Even if you have to invert the logic of the
ACPI method, it would make more sense to users.  They don't need to know
what's going on under the hood.

Good idea. I updated the patch:

http://people.freebsd.org/~rafan/acpi_ibm_radio_switch.diff

If you have ThinkPad other than X60, please help test this.

Thanks,
Rong-En Fan


--
Nate

_______________________________________________
freebsd-acpi_(_at_)_freebsd_(_dot_)_org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-acpi
To unsubscribe, send any mail to "freebsd-acpi-unsubscribe_(_at_)_freebsd_(_dot_)_org"


Visit your host, monkey.org